Skip to content

[jni] Migrate to built-in Kotlin#3477

Merged
liamappelbe merged 1 commit into
mainfrom
jni_migration
Jul 20, 2026
Merged

[jni] Migrate to built-in Kotlin#3477
liamappelbe merged 1 commit into
mainfrom
jni_migration

Conversation

@liamappelbe

@liamappelbe liamappelbe commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

PR Health ⚠️

Health checks are rerunning. These details are out-of-date.

@dcharkes dcharkes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM!

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@buenaflor

Copy link
Copy Markdown
Contributor

Curious whether the bump to Dart 3.12/Flutter 3.44 is needed - the migration guide also has a section for plugins that support versions below Flutter 3.44

@liamappelbe

Copy link
Copy Markdown
Contributor Author

Curious whether the bump to Dart 3.12/Flutter 3.44 is needed - the migration guide also has a section for plugins that support versions below Flutter 3.44

No strong reason, I just figured it'd be easier that way, and I have a low bar for bumping the Dart/Flutter version. But it's actually turned out that the version bump has been pretty disruptive to github CI, and by comparison the other migration where we support older flutter versions is trivial (no changes needed except the gradle change). So I'll switch over to that approach.

@liamappelbe
liamappelbe merged commit 3168d46 into main Jul 20, 2026
54 of 55 checks passed
@liamappelbe
liamappelbe deleted the jni_migration branch July 20, 2026 01:07
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 92.083%. remained the same — jni_migration into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[jni][jni_flutter] Android Gradle scripts break on AGP 9 built-in Kotlin (android.builtInKotlin=true)

5 participants